Updates controller-runtime, remove WriteSVIDToDir #7214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshVanL
commented
Nov 17, 2023
| @@ -236,11 +236,12 @@ func (m *AppManager) WaitUntilJobState(isState func(*batchv1.Job, error) bool) ( | |||
|
|
|||
| var lastJob *batchv1.Job | |||
|
|
|||
| waitErr := wait.PollImmediate(PollInterval, PollTimeout, func() (bool, error) { | |||
There was a problem hiding this comment.
wait.PollImmediate has been deprecated.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7214 +/- ##
==========================================
+ Coverage 62.20% 62.35% +0.15%
==========================================
Files 240 240
Lines 22112 22053 -59
==========================================
- Hits 13755 13752 -3
+ Misses 7210 7157 -53
+ Partials 1147 1144 -3 ☔ View full report in Codecov by Sentry. |
daixiang0
reviewed
Nov 24, 2023
| opts.ByObject = getTransformerFunctions(podSelector) | ||
| if len(namespace) > 0 { | ||
| opts.DefaultNamespaces = map[string]cache.Config{ | ||
| namespace: {}, |
There was a problem hiding this comment.
Not use namespace, is it really useful?
There was a problem hiding this comment.
Yes, this sets the namespaces which should be watched, see here.
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
from
d92e219
to
45fdb31
Compare
JoshVanL
added
the
autoupdate
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
from
54f77c8
to
bcc7f08
Compare
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
from
8b787cd
to
b353470
Compare
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
from
cc2542a
to
fd36f23
Compare
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
2 times, most recently
from
9c14eb0
to
e70d815
Compare
Open
PR updates go modules, specifically controller-runtime to v0.16.3 so that the webhook server can be configured to use TLS options. This removes the need for the operator to write the SVID to disk and maintain it in memory. PR removes the WriteSVIDToDir option from security. Operator cache has been updated to use new controller-runtime types. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
v2 Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
go-mod-update-operator-tls-opts
branch
from
8beeee7
to
dd3f6b4
Compare
|
/test-version-skew |
Dapr Version Skew integration test (control-plane-master - 1.12.4)Commit ref: 5621210 ❌ Version Skew tests failedPlease check the logs for details on the error. |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.4)Commit ref: 5621210 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.4)Commit ref: 5621210 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.4)Commit ref: 5621210 ❌ Version Skew tests failedPlease check the logs for details on the error. |
|
/version-skew-test |
|
/test-version-skew |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.4)Commit ref: 880e34e ✅ Version Skew tests passed |
Dapr Version Skew integration test (control-plane-master - 1.12.4)Commit ref: 880e34e ✅ Version Skew tests passed |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.4)Commit ref: 880e34e ❌ Version Skew tests failedPlease check the logs for details on the error. |
Dapr Version Skew e2e test (control-plane-master - 1.12.4)Commit ref: 880e34e ✅ Version Skew tests passed |
|
/test-version-skew |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.4)Commit ref: c899877 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.4)Commit ref: c899877 ✅ Version Skew tests passed |
Dapr Version Skew integration test (control-plane-master - 1.12.4)Commit ref: c899877 ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.4)Commit ref: c899877 ✅ Version Skew tests passed |
yaron2
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates go modules, specifically controller-runtime to v0.16.3 so that the webhook server can be configured to use TLS options. This removes the need for the operator to write the SVID to disk and maintain it in memory.
PR removes the WriteSVIDToDir option from security.
Operator cache has been updated to use new controller-runtime types.
Related: #5756