-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hot Reloading: SelfHosted Component hot reloading #7239
Changes from 14 commits
9d21f45
7cdbbc2
0157b7f
a208b8a
9f9d71d
d0dd3a3
c1d7d1b
cf97305
ce16f37
0132a49
bd83f7f
43e053a
e12fed3
cf453bc
8607abb
4c0384f
1e8c130
3e89b02
4bded36
3520e01
b5a301d
ce276d6
f399ece
d9536e0
3ce38c1
5917eca
022a3df
48ccdc0
ad265de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,13 @@ limitations under the License. | |
|
||
package apis | ||
|
||
import "github.com/dapr/dapr/pkg/apis/common" | ||
import ( | ||
"fmt" | ||
|
||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
"github.com/dapr/dapr/pkg/apis/common" | ||
) | ||
|
||
type GenericNameValueResource struct { | ||
Name string | ||
|
@@ -42,3 +48,11 @@ func (g GenericNameValueResource) GetSecretStore() string { | |
func (g GenericNameValueResource) NameValuePairs() []common.NameValuePair { | ||
return g.Pairs | ||
} | ||
|
||
func (g GenericNameValueResource) LogName() string { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this instead implement the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is consistent with other API types https://github.com/dapr/dapr/blob/master/pkg/apis/components/v1alpha1/types.go#L45 |
||
return fmt.Sprintf("%s (%s)", g.Name, g.ResourceKind) | ||
} | ||
|
||
func (g GenericNameValueResource) EmptyMetaDeepCopy() metav1.Object { | ||
return &metav1.ObjectMeta{Name: g.Name} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the scenarios that this can happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's common/best practice to have the zero enum value to be
UNKNOWN
https://stackoverflow.com/questions/10392952/how-to-design-for-a-future-additional-enum-value-in-protocol-buffers