Helm: Add option to deploy Placement with zero replicas #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dapr_placement.scaleZero` option passed to Helm causes the Placement StatefulSet to be deployed but with 0 replicas, regardless of the values of `dapr_placement.ha` or `global.ha.enabled`. This is useful in a few niche scenarios, where it's desirable to have the StatefulSet created, but in a "paused" (i.e. scaled to zero) state, to be able to scale it up later. > This is different from setting `global.actors.enabled=false`, which causes the Placement StatefulSet, and its related Service etc, to not be deployed at all Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
added
the
autoupdate
|
@ItalyPaleAle |
Ok. This doesn't change code however, just adds an option to the chart (untestable with CI) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7253 +/- ##
==========================================
- Coverage 64.47% 64.45% -0.02%
==========================================
Files 238 236 -2
Lines 21814 21669 -145
==========================================
- Hits 14064 13967 -97
+ Misses 6542 6505 -37
+ Partials 1208 1197 -11 ☔ View full report in Codecov by Sentry. |
…scale-zero Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
mukundansundar
approved these changes
Jan 9, 2024
mukundansundar
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dapr_placement.scaleZerooption passed to Helm causes the Placement StatefulSet to be deployed but with 0 replicas, regardless of the values ofdapr_placement.haorglobal.ha.enabled.This is useful in a few niche scenarios, where it's desirable to have the StatefulSet created, but in a "paused" (i.e. scaled to zero) state, to be able to scale it up later.