Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Daprd option --dapr-block-shutdown-duration #7268

Merged
merged 8 commits into from
Dec 6, 2023

Commits on Dec 4, 2023

  1. Adds Daprd option --block-shutdown-seconds

    Closes dapr#4313
    Docs: dapr/docs#3893
    
    PR adds the `--block-shutdown-seconds` CLI flag and corresponding
    `dapr.io/block-shutdown-seconds` Kubernetes annotation which configures
    Daprd to block the graceful shutdown procedure until _either_, the
    block shutdown seconds has elapsed _or_ the application has become
    unhealthy, as according to the normal app health status.
    
    By default, this option is unset, and therefore there is no effect to
    the current behaviour of graceful shutdown. When set, Daprd will
    block the interrupt signal cascading into runtime until the above
    requirements have been met.
    
    The framework process `Cleanup` order has been reversed to mimic
    `t.Cleanup` and allow the `logline` process to function correctly.
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4396bf2 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Revert if check on killing process exec proc cleanup

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    822824e View commit details
    Browse the repository at this point in the history
  2. Revert error ignore of processes already killed in unix

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    83ecc61 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7c73d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8dcfa9a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    64f2595 View commit details
    Browse the repository at this point in the history
  6. Linting

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b1684bd View commit details
    Browse the repository at this point in the history
  7. Updates dapr-block-shutdown-seconds to dapr-block-shutdown-duration

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    918e08a View commit details
    Browse the repository at this point in the history