-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Daprd option --dapr-block-shutdown-duration
#7268
Merged
Merged
Commits on Dec 4, 2023
-
Adds Daprd option
--block-shutdown-seconds
Closes dapr#4313 Docs: dapr/docs#3893 PR adds the `--block-shutdown-seconds` CLI flag and corresponding `dapr.io/block-shutdown-seconds` Kubernetes annotation which configures Daprd to block the graceful shutdown procedure until _either_, the block shutdown seconds has elapsed _or_ the application has become unhealthy, as according to the normal app health status. By default, this option is unset, and therefore there is no effect to the current behaviour of graceful shutdown. When set, Daprd will block the interrupt signal cascading into runtime until the above requirements have been met. The framework process `Cleanup` order has been reversed to mimic `t.Cleanup` and allow the `logline` process to function correctly. Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for 4396bf2 - Browse repository at this point
Copy the full SHA 4396bf2View commit details
Commits on Dec 5, 2023
-
Revert if check on killing process exec proc cleanup
Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for 822824e - Browse repository at this point
Copy the full SHA 822824eView commit details -
Revert error ignore of processes already killed in unix
Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for 83ecc61 - Browse repository at this point
Copy the full SHA 83ecc61View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7c73d4 - Browse repository at this point
Copy the full SHA d7c73d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dcfa9a - Browse repository at this point
Copy the full SHA 8dcfa9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64f2595 - Browse repository at this point
Copy the full SHA 64f2595View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1684bd - Browse repository at this point
Copy the full SHA b1684bdView commit details -
Updates
dapr-block-shutdown-seconds
todapr-block-shutdown-duration
Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for 918e08a - Browse repository at this point
Copy the full SHA 918e08aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.