Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppChannelAllowInsecureTls flag #7292

Merged
merged 7 commits into from Dec 20, 2023

Conversation

DeepanshuA
Copy link
Contributor

Description

Removes AppChannelAllowInsecurerTLS flag, as it needs to be removed in 1.13

Issue reference

Please reference the issue this PR will close: #7149

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA marked this pull request as ready for review December 12, 2023 11:18
@DeepanshuA DeepanshuA requested review from a team as code owners December 12, 2023 11:18
@JoshVanL JoshVanL added this to the v1.13 milestone Dec 12, 2023
mukundansundar
mukundansundar previously approved these changes Dec 13, 2023
@mukundansundar
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 13, 2023

Dapr E2E test

🔗 Link to Action run

Commit ref: 00aacda

✅ Build succeeded for linux/amd64

  • Image tag: dapre2e5ee9aebfdbl
  • Test image tag: dapre2e5ee9aebfdbl

✅ Infrastructure deployed

Cluster Resource group name Azure region
Linux Dapr-E2E-dapre2e5ee9aebfdbl westus3
Windows Dapr-E2E-dapre2e5ee9aebfdbw westus3
Linux/arm64 Dapr-E2E-dapre2e5ee9aebfdbla eastus

✅ Build succeeded for windows/amd64

  • Image tag: dapre2e5ee9aebfdbw
  • Test image tag: dapre2e5ee9aebfdbw

✅ Tests succeeded on windows/amd64

  • Image tag: dapre2e5ee9aebfdbw
  • Test image tag: dapre2e5ee9aebfdbw

✅ Tests succeeded on linux/amd64

  • Image tag: dapre2e5ee9aebfdbl
  • Test image tag: dapre2e5ee9aebfdbl

@mukundansundar mukundansundar added automerge Allows DaprBot to automerge and update PR if all approvals are in place autoupdate DaprBot will keep the Pull Request up to date with master branch labels Dec 13, 2023
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (d7775f8) 64.59% compared to head (8657a19) 64.62%.
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/runtime/wfengine/workflow.go 65.90% 8 Missing and 7 partials ⚠️
pkg/grpc/manager/manager.go 0.00% 2 Missing ⚠️
pkg/runtime/wfengine/backend.go 80.00% 1 Missing and 1 partial ⚠️
pkg/runtime/channels/channels.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7292      +/-   ##
==========================================
+ Coverage   64.59%   64.62%   +0.02%     
==========================================
  Files         226      226              
  Lines       21191    21219      +28     
==========================================
+ Hits        13689    13712      +23     
- Misses       6324     6325       +1     
- Partials     1178     1182       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukundansundar mukundansundar merged commit 5363a2d into dapr:master Dec 20, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Allows DaprBot to automerge and update PR if all approvals are in place autoupdate DaprBot will keep the Pull Request up to date with master branch
Projects
Development

Successfully merging this pull request may close these issues.

Presence of AppChannelAllowInsecureTLS feature flag
5 participants