New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AppChannelAllowInsecureTls flag #7292
Merged
mukundansundar
merged 7 commits into
dapr:master
from
DeepanshuA:allowInsecureTlsRemoval
Dec 20, 2023
Merged
Remove AppChannelAllowInsecureTls flag #7292
mukundansundar
merged 7 commits into
dapr:master
from
DeepanshuA:allowInsecureTlsRemoval
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
mukundansundar
previously approved these changes
Dec 13, 2023
/ok-to-test |
Dapr E2E testCommit ref: 00aacda ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
mukundansundar
added
automerge
Allows DaprBot to automerge and update PR if all approvals are in place
autoupdate
DaprBot will keep the Pull Request up to date with master branch
labels
Dec 13, 2023
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle
approved these changes
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7292 +/- ##
==========================================
+ Coverage 64.59% 64.62% +0.02%
==========================================
Files 226 226
Lines 21191 21219 +28
==========================================
+ Hits 13689 13712 +23
- Misses 6324 6325 +1
- Partials 1178 1182 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Allows DaprBot to automerge and update PR if all approvals are in place
autoupdate
DaprBot will keep the Pull Request up to date with master branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes AppChannelAllowInsecurerTLS flag, as it needs to be removed in 1.13
Issue reference
Please reference the issue this PR will close: #7149
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: