Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] Fix timeouts in HTTP service invocation when resiliency policies with timeouts are applied #7310

Merged
merged 2 commits into from
Dec 16, 2023
Merged

[release-1.12] Fix timeouts in HTTP service invocation when resiliency policies with timeouts are applied #7310

merged 2 commits into from
Dec 16, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

Backport of #7270

@ItalyPaleAle
[release-1.12] Fix timeouts in HTTP service invocation when resilienc…
5644949 
…y policies with timeouts are applied

Backport of dapr#7270

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle
Added release notes
06b17dc 
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners December 16, 2023 19:10
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9ec8497) 64.81% compared to head (06b17dc) 64.78%.

Files Patch % Lines
pkg/resiliency/policy.go 66.66% 4 Missing ⚠️
pkg/http/api_directmessaging.go 94.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.12    #7310      +/-   ##
================================================
- Coverage         64.81%   64.78%   -0.04%     
================================================
  Files               231      231              
  Lines             20940    20951      +11     
================================================
  Hits              13573    13573              
- Misses             6234     6243       +9     
- Partials           1133     1135       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2 yaron2 merged commit 9b6836f into dapr:release-1.12 Dec 16, 2023
18 of 21 checks passed
@JoshVanL JoshVanL mentioned this pull request Dec 19, 2023
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ItalyPaleAle @yaron2