-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cascade terminate/Purge Workflow Support #7340
Merged
mukundansundar
merged 43 commits into
dapr:master
from
shivamkm07:cascade_terminatePurgeWf
Jan 17, 2024
Merged
Changes from 40 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
751722f
Updating protos
shivamkm07 ea2dedc
enable recursive terminate/purge
shivamkm07 5175161
Updating dtf-go
shivamkm07 24f3e7d
updating contrib
shivamkm07 abe6005
Correct proto generated files
shivamkm07 41e16a4
update comment
shivamkm07 bb0be0e
Merge branch 'master' into cascade_terminatePurgeWf
mukundansundar 2d55758
implementing getOrchestrationRuntimeState
shivamkm07 89e0084
Adding unit tests
shivamkm07 56273a1
Merge branch 'master' into cascade_terminatePurgeWf
shivamkm07 04ca172
Merge branch 'master' into cascade_terminatePurgeWf
daixiang0 1d15ad8
merge master
shivamkm07 1f76406
Merge branch 'master' into cascade_terminatePurgeWf
mukundansundar b5ceb30
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 65bebca
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot eeaed71
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot d9ff995
Merge branch 'master' into cascade_terminatePurgeWf
mukundansundar 7e4c476
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot fb499a6
make modtidy-all
shivamkm07 d7e7ffb
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 4ac7bcf
Adding recursive option in query parameter
shivamkm07 f02762d
Adding integration test for workflow
shivamkm07 7a53708
fix bug in Creating sub-orchestrations
shivamkm07 b20da16
Merge remote-tracking branch 'upstream/master' into cascade_terminate…
shivamkm07 9c4312d
Setting recursive/terminate purge to default and adding tests for same
shivamkm07 f61361b
linter fixes
shivamkm07 bfa7fed
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 7a573e8
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 9e8ba8d
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot e3938f8
merge master
shivamkm07 507c3f6
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 56dca91
Removing fix from this PR
shivamkm07 49db0dd
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 1a87247
Merge branch 'master' into cascade_terminatePurgeWf
mukundansundar b456cb0
merge master
shivamkm07 614fc7c
renaming to
shivamkm07 ba65bde
linter fixes
shivamkm07 b5f8c4b
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 86f9b63
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 3dce3f5
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 1d033a0
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 5150403
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot 87ef171
Merge branch 'master' into cascade_terminatePurgeWf
dapr-bot File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this
recursive
instead ofnon_recursive
? It's harder for people to understand negatives.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only concern I have here is, in general query string default parameters when not specified are the default values like false, 0 etc.
By defaulting to recursive terminate/purge and then asking users to set
?recursive=false
does not seem intuitive to me, rather at that point setting?non_recursive=true
make it more intuitive IMO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of incline towards
recursive
set totrue
by default. Understanding this was quite easier for me.Is there any reasoning behind keeping all flags to false by default, apart from general practice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally agree with Mukundan that it's more intuitive when the default value of a boolean is false.
If the default value is "true", then you are introducing 3 states: set true, set false, null.