BugFix: Fixed Concurrency Issue in file pkg/actors/actors.go

[fazledyn-or]

Description

While triaging this project, our bug fixing tool found an error in file actors.go. In that file, there's a bug related to channel errCh, where an in-equal number of send operation is performed than receive operation.

We've inspected the code and prepared a fix for it. Please refer to the issue for further details.

Issue reference

Please reference the issue this PR will close: #7380

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Unit tests passing
• End-to-end tests passing
• Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
• Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
• Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).

- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

[daixiang0]

Good catch!

[codecov]

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (51dc3a1) 64.31% compared to head (9b620fd) 62.16%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
pkg/runtime/wfengine/backends/actors/backend.go	0.00%	40 Missing ⚠️
pkg/runtime/wfengine/component.go	0.00%	22 Missing ⚠️
pkg/runtime/wfengine/wfengine.go	71.87%	8 Missing and 1 partial ⚠️
pkg/runtime/runtime.go	72.72%	5 Missing and 1 partial ⚠️
pkg/runtime/meta/meta.go	20.00%	4 Missing ⚠️
pkg/runtime/processor/manager.go	0.00%	3 Missing ⚠️
pkg/actors/actors.go	0.00%	2 Missing ⚠️
pkg/api/universal/universal.go	0.00%	1 Missing ⚠️
pkg/api/universal/workflow.go	85.71%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7381      +/-   ##
==========================================
- Coverage   64.31%   62.16%   -2.15%     
==========================================
  Files         238      239       +1     
  Lines       21877    21942      +65     
==========================================
- Hits        14070    13641     -429     
- Misses       6598     7168     +570     
+ Partials     1209     1133      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.