Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate headers on non successful responses #7403

Merged
merged 1 commit into from Jan 18, 2024

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jan 18, 2024

Fixes #7371.

Signed-off-by: yaron2 <schneider.yaron@live.com>
@yaron2 yaron2 requested review from a team as code owners January 18, 2024 00:32
@yaron2 yaron2 merged commit f314b49 into dapr:master Jan 18, 2024
12 of 15 checks passed
@yaron2 yaron2 deleted the headers-1 branch January 18, 2024 01:26
@mohit-clootrack
Copy link

mohit-clootrack commented Jan 18, 2024

Any timeline on when this fix will be released? This particular issue is causing problems in many environments with nginx loadbalancer.
nginx does not allow duplicate response headers.

@yaron2
Copy link
Member Author

yaron2 commented Jan 18, 2024

Any timeline on when this fix will be released? This particular issue is causing problems in many environments with nginx loadbalancer. nginx does not allow duplicate response headers.

This is coming out in the 1.13 release, slated for Jan 30

whytem pushed a commit to whytem/dapr that referenced this pull request Jan 22, 2024
Signed-off-by: yaron2 <schneider.yaron@live.com>
elena-kolevska pushed a commit to elena-kolevska/dapr that referenced this pull request Jan 24, 2024
Signed-off-by: yaron2 <schneider.yaron@live.com>
elena-kolevska added a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024
elena-kolevska pushed a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024
Signed-off-by: yaron2 <schneider.yaron@live.com>
elena-kolevska pushed a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska added a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024
This reverts commit aeb2a44.

Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska pushed a commit to elena-kolevska/dapr that referenced this pull request Jan 25, 2024
Signed-off-by: yaron2 <schneider.yaron@live.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@JoshVanL JoshVanL added this to the v1.13 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http service invocation in verion 1.12.3.
4 participants