New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent invalid traceparent ("00-00000...") from being returned to the caller #7406
Merged
artursouza
merged 7 commits into
dapr:master
from
KarstenWintermann:KarstenWintermann/issue7372
Jan 19, 2024
Merged
Prevent invalid traceparent ("00-00000...") from being returned to the caller #7406
artursouza
merged 7 commits into
dapr:master
from
KarstenWintermann:KarstenWintermann/issue7372
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e caller Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com>
@KarstenWintermann see the linter failure |
…h Kafka Fixes dapr#7372 Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com>
OK, fixed it |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7406 +/- ##
==========================================
- Coverage 62.24% 62.23% -0.02%
==========================================
Files 240 240
Lines 22137 22138 +1
==========================================
- Hits 13779 13777 -2
- Misses 7208 7210 +2
- Partials 1150 1151 +1 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Jan 18, 2024
whytem
pushed a commit
to whytem/dapr
that referenced
this pull request
Jan 22, 2024
…e caller (dapr#7406) * Prevent invalid traceparent ("00-00000...") from being returned to the caller Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> * OpenTelemetry trace context not transmitted when using rawPayload with Kafka Fixes dapr#7372 Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> --------- Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 24, 2024
…e caller (dapr#7406) * Prevent invalid traceparent ("00-00000...") from being returned to the caller Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> * OpenTelemetry trace context not transmitted when using rawPayload with Kafka Fixes dapr#7372 Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> --------- Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com>
elena-kolevska
pushed a commit
to elena-kolevska/dapr
that referenced
this pull request
Jan 25, 2024
…e caller (dapr#7406) * Prevent invalid traceparent ("00-00000...") from being returned to the caller Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> * OpenTelemetry trace context not transmitted when using rawPayload with Kafka Fixes dapr#7372 Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> --------- Signed-off-by: Karsten Wintermann <58027075+KarstenWintermann@users.noreply.github.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com> Co-authored-by: Artur Souza <asouza.pro@gmail.com> Signed-off-by: Elena Kolevska <elena@kolevska.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karsten Wintermann 58027075+KarstenWintermann@users.noreply.github.com
Description
Added a check in http_channel.go which prevents an empty traceparent header from being returned to the caller.
This way, valid traceparent headers, which may be received from Kafka topics with raw payloads, are not overwritten.
Issue reference
Please reference the issue this PR will close: #7372
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: