Disable placement timeout with no peers #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable placement leadership timeouts when there are no peers. This
reduces startup time of placement by a second. Also remove initial delay
of actor health check probe.
Continue to use existing placement config if there is more then one peer
(initial cluster) configured i.e. ha mode.
`-focus "actor|placement" integration test results before and after
change:
```
integration.go:82: Total integration test execution time: 2m2.7s
integration.go:82: Total integration test execution time: 2m5.9s
integration.go:82: Total integration test execution time: 1m36.3s
integration.go:82: Total integration test execution time: 1m35s
``
Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7418 +/- ##
==========================================
- Coverage 62.40% 62.36% -0.04%
==========================================
Files 244 244
Lines 22134 22139 +5
==========================================
- Hits 13812 13807 -5
- Misses 7181 7195 +14
+ Partials 1141 1137 -4 ☔ View full report in Codecov by Sentry. |
|
/test-version-skew |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.4)Commit ref: c94bdde ✅ Version Skew tests passed |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.4)Commit ref: c94bdde ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.4)Commit ref: c94bdde ✅ Version Skew tests passed |
Dapr Version Skew integration test (control-plane-master - 1.12.4)Commit ref: c94bdde ✅ Version Skew tests passed |
JoshVanL
added
the
autoupdate
yaron2
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable placement leadership timeouts when there are no peers. This reduces startup time of placement by a second. Also remove initial delay of actor health check probe.
Continue to use existing placement config if there is more then one peer (initial cluster) configured i.e. ha mode.
`-focus "actor|placement" integration test results before and after change: