Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ns to sentry ca bundle cm #7420

Merged
merged 1 commit into from Jan 20, 2024
Merged

Conversation

emctl
Copy link
Contributor

@emctl emctl commented Jan 20, 2024

Description

When using Helmfile template and the dapr helm chart, it looked like there was an issue with where the configmap for sentry's trust bundle was not deployed to the correct namespace with all other resources.

time="2024-01-20T18:05:21.163511861Z" level=info msg="Starting watch on filesystem directory: /var/run/secrets/dapr.io/credentials" instance=dapr-sentry-5f7d7d5c6f-rb864 scope=dapr.sentry type=log ver=1.12.4
time="2024-01-20T18:05:21.169062111Z" level=info msg="Healthz server is shutting down" instance=dapr-sentry-5f7d7d5c6f-rb864 scope=dapr.sentry type=log ver=1.12.4
time="2024-01-20T18:05:21.189430929Z" level=fatal msg="error creating CA: configmaps \"dapr-trust-bundle\" not found" instance=dapr-sentry-5f7d7d5c6f-rb864 scope=dapr.sentry type=log ver=1.12.4
kubectl get cm -n dapr-system
NAME               DATA   AGE
kube-root-ca.crt   1      58m

kubectl get cm -n default
NAME                DATA   AGE
kube-root-ca.crt    1      5h35m
dapr-trust-bundle   0      20m

Upon moving the config to the correct namespace:

kubectl get cm dapr-trust-bundle --namespace=default -o yaml \
  | sed 's/namespace: default/namespace: dapr-system/' \
  | kubectl create -f -

configmap/dapr-trust-bundle created

kubectl rollout restart deploy/dapr-sentry -n dapr-system
kubectl rollout restart deploy/dapr-operator -n dapr-system
kubectl rollout restart statefulsets/dapr-placement-server -n dapr-system

deployment.apps/dapr-sentry restarted
deployment.apps/dapr-operator restarted
statefulset.apps/dapr-placement-server restarted

kubectl get po -n dapr-system
NAME                                     READY   STATUS    RESTARTS   AGE
dapr-sentry-7c9d66f677-k592l             1/1     Running   0          5m21s
dapr-operator-7ddfbccb48-qbngq           1/1     Running   0          5m21s
dapr-placement-server-0                  1/1     Running   0          5m19s
dapr-sidecar-injector-79448bb544-cpl75   1/1     Running   0          29m

Issue reference

No Issue I noticed, happy to open one.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@emctl emctl requested review from a team as code owners January 20, 2024 18:38
@yaron2
Copy link
Member

yaron2 commented Jan 20, 2024

@JoshVanL for review

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffa8061) 62.21% compared to head (e9649d6) 62.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7420   +/-   ##
=======================================
  Coverage   62.21%   62.21%           
=======================================
  Files         240      240           
  Lines       22112    22112           
=======================================
+ Hits        13756    13757    +1     
- Misses       7205     7209    +4     
+ Partials     1151     1146    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2 yaron2 added this to the v1.13 milestone Jan 20, 2024
@yaron2 yaron2 merged commit f6015e8 into dapr:master Jan 20, 2024
21 of 22 checks passed
whytem pushed a commit to whytem/dapr that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants