Fix pubsub metadata conflict #7421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This run proves that the E2E test changes repro the issue (using a custom contrib version that has Redis handling metadata): https://github.com/dapr/dapr/actions/runs/7596929989/job/20691187869 |
artursouza
force-pushed
the
fix_pubsub_metadata_conflict
branch
from
6cde381
to
f9ebd03
Compare
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
fix_pubsub_metadata_conflict
branch
from
f9ebd03
to
5778e35
Compare
This reverts commit 20b60a0. Signed-off-by: Artur Souza <asouza.pro@gmail.com>
artursouza
force-pushed
the
fix_pubsub_metadata_conflict
branch
from
5778e35
to
dba7cc7
Compare
|
PR is ready for review WITHOUT the Redis change. It means the E2E test will always pass, regardless of the bug being present or not because Redis just drops the metadata. |
|
Once Redis has this feature in 1.14, the E2E test will do its intended purpose. I tested this with an override pointing to my contrib fork. So, the E2E test is confirmed to repro the issue once Redis handles metadata. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7421 +/- ##
=======================================
Coverage 62.34% 62.35%
=======================================
Files 240 240
Lines 22053 22058 +5
=======================================
+ Hits 13750 13755 +5
- Misses 7160 7161 +1
+ Partials 1143 1142 -1 ☔ View full report in Codecov by Sentry. |
yaron2
approved these changes
Jan 22, 2024
artursouza
added a commit
to artursouza/dapr
that referenced
this pull request
Feb 9, 2024
* Temporary override to have Redis to handle event metadata. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * E2E test change to reproduce HTTP header conflict in pubsub. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * E2E test for content-length conflict with gRPC subscriber. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Hotfix to avoid content-length header conflict in HTTP and gRPC. Signed-off-by: Artur Souza <asouza.pro@gmail.com> * Revert "Temporary override to have Redis to handle event metadata." This reverts commit 20b60a0. Signed-off-by: Artur Souza <asouza.pro@gmail.com> --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com>
7 tasks
yaron2
pushed a commit
that referenced
this pull request
Feb 10, 2024
* Temporary override to have Redis to handle event metadata. * E2E test change to reproduce HTTP header conflict in pubsub. * E2E test for content-length conflict with gRPC subscriber. * Hotfix to avoid content-length header conflict in HTTP and gRPC. * Revert "Temporary override to have Redis to handle event metadata." This reverts commit 20b60a0. --------- Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where pubsub event metadata can conflict with gRPC metadata and make the message undeliverable.
Issue reference
Please reference the issue this PR will close: #7413
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: