-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow backends: ignore on hot reloading #7433
Workflow backends: ignore on hot reloading #7433
Commits on Jan 29, 2024
-
Workflow backends: exit error on hot reload
Updates the hot reloading reconciler so that Daprd will exit error when a workflowbackend Component is hot reloaded. This is chosen because today, the actors and workflow subsystems are not written with any closing or dynamic support. Doing so will cause panics/corruption in its current state. Exiting error is the safest option as this ensures consistency across a replica set and ensures there is no surprise for the user that behaviour does not match given configuration. Adds integration tests for daprd ensuring workflow backends can be loaded on boot. Adds tests to ensure daprd will exist error on a workflow backend being hot reloaded. We should do the same for actor state store and the actor subsystem. Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for ed5bc00 - Browse repository at this point
Copy the full SHA ed5bc00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b15450 - Browse repository at this point
Copy the full SHA 2b15450View commit details -
Update workflowbackend int tests for removed workflow comoponent
registered Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for 6bc848d - Browse repository at this point
Copy the full SHA 6bc848dView commit details -
Fix namespacing in workflowbackend integration test
Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for ba58da7 - Browse repository at this point
Copy the full SHA ba58da7View commit details -
Configuration menu - View commit details
-
Copy full SHA for b10fe79 - Browse repository at this point
Copy the full SHA b10fe79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e4887 - Browse repository at this point
Copy the full SHA 80e4887View commit details -
Changes hot reloading to only log an error when workflow backend is
reconciled Signed-off-by: joshvanl <me@joshvanl.dev>
Configuration menu - View commit details
-
Copy full SHA for c0358f6 - Browse repository at this point
Copy the full SHA c0358f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d41a558 - Browse repository at this point
Copy the full SHA d41a558View commit details
Commits on Jan 30, 2024
-
Merge branch 'master' into hotreloading-workflowbackends-exit1
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0d130fb - Browse repository at this point
Copy the full SHA 0d130fbView commit details -
Fix bad merge conflict resolution.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b33a1e4 - Browse repository at this point
Copy the full SHA b33a1e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0227d6f - Browse repository at this point
Copy the full SHA 0227d6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0607ef9 - Browse repository at this point
Copy the full SHA 0607ef9View commit details