Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow backends: ignore on hot reloading #7433

Merged
merged 12 commits into from
Jan 30, 2024

Commits on Jan 29, 2024

  1. Workflow backends: exit error on hot reload

    Updates the hot reloading reconciler so that Daprd will exit error when
    a workflowbackend Component is hot reloaded. This is chosen because
    today, the actors and workflow subsystems are not written with any
    closing or dynamic support. Doing so will cause panics/corruption in its
    current state.
    
    Exiting error is the safest option as this ensures consistency across a
    replica set and ensures there is no surprise for the user that
    behaviour does not match given configuration.
    
    Adds integration tests for daprd ensuring workflow backends can be
    loaded on boot.
    
    Adds tests to ensure daprd will exist error on a workflow backend being
    hot reloaded.
    
    We should do the same for actor state store and the actor subsystem.
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ed5bc00 View commit details
    Browse the repository at this point in the history
  2. Review loop

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    2b15450 View commit details
    Browse the repository at this point in the history
  3. Update workflowbackend int tests for removed workflow comoponent

    registered
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    6bc848d View commit details
    Browse the repository at this point in the history
  4. Fix namespacing in workflowbackend integration test

    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    ba58da7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b10fe79 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    80e4887 View commit details
    Browse the repository at this point in the history
  7. Changes hot reloading to only log an error when workflow backend is

    reconciled
    
    Signed-off-by: joshvanl <me@joshvanl.dev>
    JoshVanL committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c0358f6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d41a558 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Merge branch 'master' into hotreloading-workflowbackends-exit1

    Signed-off-by: Artur Souza <asouza.pro@gmail.com>
    artursouza committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0d130fb View commit details
    Browse the repository at this point in the history
  2. Fix bad merge conflict resolution.

    Signed-off-by: Artur Souza <asouza.pro@gmail.com>
    artursouza committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b33a1e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0227d6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0607ef9 View commit details
    Browse the repository at this point in the history