Block Graceful Shutdown: stop input bindings and subscriptions #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst Dapr should keep available outgoing API requests whilst blocking graceful shutdown, we want to prevent incoming input bindings and subscriptions from receiving new messages. PR updates the block graceful shutdown to forever stop input bindings and subscriptions from being read. Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7474 +/- ##
==========================================
- Coverage 62.31% 62.26% -0.05%
==========================================
Files 244 244
Lines 22271 22285 +14
==========================================
- Hits 13878 13876 -2
- Misses 7248 7260 +12
- Partials 1145 1149 +4 ☔ View full report in Codecov by Sentry. |
ItalyPaleAle
approved these changes
Feb 1, 2024
yaron2
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst Dapr should keep available outgoing API requests whilst blocking graceful shutdown, we want to prevent incoming input bindings and subscriptions from receiving new messages.
PR updates the block graceful shutdown to forever stop input bindings and subscriptions from being read.