-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding recursive terminate/purge in workflow API #3969
Conversation
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review
Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
@shivamkm07 - This needs more updates in the docs. Specifically we should cover this in the Child workflows section
|
Thanks for the review. Will add sections accordingly.
This was actually decided to be kept as |
@shivamkm07 @msfussell I can do this in a separate PR, unless Shivam you'd rather take this? |
Sure, feel free to create separate PR for this. I will include 1 and 2 above in this PR. |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
@msfussell @hhunter-ms Added requested changes 1 and 2. Please review. |
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
This PR adds details about recursive termination/purge of child workflows in workflow api documentation.
Issue reference
Please reference the issue this PR will close: #3949