feat: workflow authoring and management support #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeee
force-pushed
the
mikeee-feat-workflow-authoring
branch
from
facf3ee
to
3ae03a4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
===========================================
- Coverage 70.11% 59.37% -10.74%
===========================================
Files 35 54 +19
Lines 2884 3483 +599
===========================================
+ Hits 2022 2068 +46
- Misses 748 1293 +545
- Partials 114 122 +8 ☔ View full report in Codecov by Sentry. |
mikeee
changed the title
mikeee
force-pushed
the
mikeee-feat-workflow-authoring
branch
from
d9f8f1c
to
74cbdbc
Compare
3 tasks
mikeee
changed the title
mikeee
force-pushed
the
mikeee-feat-workflow-authoring
branch
18 times, most recently
from
f166caf
to
328c94a
Compare
There was a problem hiding this comment.
Great start with adding in workflow support with Dapr management APIs. Just left a few comments and suggestions.
- consider adding authoring SDK
- should generics support be added instead of
any interface{}for input/output as if there are plans to add it later on that might be a breaking change? If breaking changes are ok, then this can be a future feature.
cc @yaron2 wdyt?
mikeee
force-pushed
the
mikeee-feat-workflow-authoring
branch
3 times, most recently
from
f5fa833
to
947414d
Compare
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
… errors Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
|
Looks like we can merge this. @cgillum |
4 tasks
cgillum
reviewed
Feb 7, 2024
cgillum
reviewed
Feb 7, 2024
Co-authored-by: Chris Gillum <cgillum@gmail.com> Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
cgillum
approved these changes
Feb 7, 2024
Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
- task invoke documentation - refactor type assertion for startworkflowbeta1 Signed-off-by: mikeee <hey@mike.ee>
Signed-off-by: mikeee <hey@mike.ee>
|
@yaron2 for your eyes |
|
@mikeee please resolve the conflicts and we can merge |
|
I had a feeling this would happen 😂 |
Signed-off-by: mikeee <hey@mike.ee>
|
@yaron2 good to go, not sure why codecov is unhappy but 🤷 |
yaron2
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Workflow authoring using
durabletask-goand also an interface to the dapr grpc management endpoints.Contributes towards the completion of dapr/dapr#7156 and closes #379
This PR also exposes the GRPC connection from the dapr client.
Requires documentation in dapr/docs#3895