Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to customize the default logger #496

Merged
merged 1 commit into from Feb 13, 2024
Merged

Conversation

qustavo
Copy link
Contributor

@qustavo qustavo commented Jan 16, 2024

Description

The following allows the user of the SDK to customize the global logger, as it might break some application logging format. This way one can streamline all the program logging output.

client/client.go Outdated Show resolved Hide resolved
@mikeee
Copy link
Member

mikeee commented Feb 5, 2024

https://github.com/dapr/go-sdk/pull/496/checks?check_run_id=21231094100
The commits need to be signed with the instructions above

@qustavo qustavo force-pushed the set-logger branch 2 times, most recently from bbf3be6 to cf87836 Compare February 5, 2024 16:52
Signed-off-by: Gustavo Chain <me@qustavo.cc>
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qustavo
Copy link
Contributor Author

qustavo commented Feb 13, 2024

@mikeee @daixiang0 : how can we get this merged?

@yaron2 yaron2 merged commit 1a347b2 into dapr:main Feb 13, 2024
4 of 5 checks passed
@yaron2
Copy link
Member

yaron2 commented Feb 13, 2024

Thanks for your contribution @qustavo

@yaron2 yaron2 added this to the v1.10 milestone Feb 13, 2024
@yaron2 yaron2 assigned mikeee and qustavo and unassigned mikeee Feb 13, 2024
@qustavo qustavo deleted the set-logger branch February 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants