Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds error payload to DaprException. #1009

Merged
merged 5 commits into from Feb 15, 2024

Conversation

artursouza
Copy link
Member

Description

Adds error payload to DaprException.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: None

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artursouza artursouza requested review from a team as code owners February 14, 2024 20:27
@artursouza artursouza added this to the v1.11 milestone Feb 14, 2024
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
cicoyle
cicoyle previously approved these changes Feb 15, 2024
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like: MethodInvokeIT.testInvokeException is failing, but otherwise looks good. Thx @artursouza

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
@artursouza
Copy link
Member Author

Looks like: MethodInvokeIT.testInvokeException is failing, but otherwise looks good. Thx @artursouza

Fixing that. Thanks.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a3cc138) 77.56% compared to head (b7cc6c9) 77.56%.

Files Patch % Lines
...rc/main/java/io/dapr/exceptions/DaprException.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1009   +/-   ##
=========================================
  Coverage     77.56%   77.56%           
- Complexity     1567     1568    +1     
=========================================
  Files           144      144           
  Lines          4751     4756    +5     
  Branches        554      554           
=========================================
+ Hits           3685     3689    +4     
  Misses          781      781           
- Partials        285      286    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants