Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project-reactor dependency & fix deprecated calls #816

Closed
wants to merge 4 commits into from

Conversation

Gonzoe79
Copy link

@Gonzoe79 Gonzoe79 commented Dec 5, 2022

updating project reactor dependency to work with spring boot 3, replacing deprecated calls to subscriberContext

Signed-off-by: Jan Czapla jan.czapla@bosch.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

updating project reactor dependency to work with spring boot 3,
replacing deprecated calls to subscriberContext

Signed-off-by: Jan Czapla <jan.czapla@bosch.com>
@Gonzoe79 Gonzoe79 requested review from a team as code owners December 5, 2022 14:35
@Gonzoe79 Gonzoe79 changed the title refs #815 Update project-reactor dependency & fix deprecated calls Dec 5, 2022
@mukundansundar
Copy link
Contributor

@Gonzoe79 can you fix the checkstyle violations?

Signed-off-by: Jan Czapla <jan.czapla@bosch.com>
Signed-off-by: Jan Czapla <jan.czapla@bosch.com>
Signed-off-by: Jan Czapla <jan.czapla@bosch.com>
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #816 (8f23f88) into master (dcee2f7) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #816      +/-   ##
============================================
+ Coverage     77.62%   77.72%   +0.09%     
- Complexity     1161     1164       +3     
============================================
  Files           105      105              
  Lines          3647     3663      +16     
  Branches        419      419              
============================================
+ Hits           2831     2847      +16     
  Misses          603      603              
  Partials        213      213              
Impacted Files Coverage Δ
...ain/java/io/dapr/actors/client/DaprGrpcClient.java 93.54% <100.00%> (ø)
...k/src/main/java/io/dapr/client/DaprClientGrpc.java 90.60% <100.00%> (+0.06%) ⬆️
...k/src/main/java/io/dapr/client/DaprClientHttp.java 87.41% <100.00%> (+0.37%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@artursouza artursouza added this to the v1.8 milestone Dec 5, 2022
@artursouza
Copy link
Member

Although this is a breaking change due to the dependency change, I can accept this PR if the integration tests pass. Please, take a look that they are all failing consistently.

@artursouza artursouza modified the milestones: v1.8, v1.9 Feb 1, 2023
@artursouza artursouza modified the milestones: v1.9, v1.10 Mar 14, 2023
@mukundansundar mukundansundar modified the milestones: v1.10, v1.11 Sep 22, 2023
@cicoyle
Copy link
Contributor

cicoyle commented Dec 21, 2023

gentle ping - @Gonzoe79

@artursouza
Copy link
Member

We already upgraded to Springboot 3. Closing PR. Thanks.

@artursouza artursouza closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants