-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add health check to wait for sidecar and test it #918
add health check to wait for sidecar and test it #918
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
This looks good to me, great work @cicoyle ! |
Signed-off-by: Cassie Coyle <cassie@diagrid.io>
If you haven't already, It's worth checking in with @artursouza as this class If that is still true, these changes also need porting over to |
Good point @olitomlinson! One issue with the gRPC |
Not that I have any say in the matter, but I think being consistent with the dotnet SDK and calling |
Signed-off-by: Cassie Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
bafccd2
to
61bc31d
Compare
61bc31d
to
3bb1916
Compare
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
abe0521
to
992aa76
Compare
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Unfortunately, this works locally on my Mac, but not in CI - trying to debug |
I reproduced this error locally. The error is because the test is not passing the interceptor to an OkHTTP client. You need this in GrpcChannelFacadeTest:
And then, use the custom okHttpClient:
It might be working locally because you might have a running sidecar and makes the test pass. |
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
0f18d95
to
e98f8d7
Compare
@@ -43,6 +64,8 @@ class GrpcChannelFacade implements Closeable { | |||
*/ | |||
GrpcChannelFacade(ManagedChannel channel) { | |||
this.channel = channel; | |||
OkHttpClient okHttpClient = new OkHttpClient.Builder().build(); | |||
this.daprHttp = new DaprHttp(Properties.SIDECAR_IP.get(), 3500, okHttpClient); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be forcing port 3500 since the sidecar can run on any port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed it. This line is not really needed, we just move the responsibility of creating the DaprHTTP instance to the caller.
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
============================================
- Coverage 76.55% 76.23% -0.33%
+ Complexity 1469 1462 -7
============================================
Files 138 138
Lines 4475 4489 +14
Branches 527 524 -3
============================================
- Hits 3426 3422 -4
- Misses 763 784 +21
+ Partials 286 283 -3 ☔ View full report in Codecov by Sentry. |
Description
Adding a health check to the wait for sidecar logic such that there is better parity with the dotnet sdk. Updated the README. Updated the
pom.xml
to fix the err:Caused by: java.lang.ClassNotFoundException: org.junit.jupiter.api.extension.ScriptEvaluationException
Issue reference
#897
Checklist