Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving and Adding Logs for Workflow #978

Merged
merged 13 commits into from
Jan 6, 2024

Conversation

RyanLettieri
Copy link
Contributor

@RyanLettieri RyanLettieri commented Dec 26, 2023

Description

Added in logging statements for dapr workflow and optional parameter for setting the log level.

Note that the failures are due to every individual case of a large switch-case statement not being tested

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #946

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
@RyanLettieri RyanLettieri marked this pull request as ready for review January 3, 2024 02:56
@RyanLettieri RyanLettieri requested review from a team as code owners January 3, 2024 02:56
@mukundansundar
Copy link
Contributor

@RyanLettieri Can you look into the coverage checks that are failing in this PR?

@RyanLettieri
Copy link
Contributor Author

@RyanLettieri Can you look into the coverage checks that are failing in this PR?

The coverage checks are due to the switch case statement for the log levels. We log what the log level was set to in the switch case statements, I.e. "Severe", "Warning", etc. I didn't believe it made much sense to create test cases for each individual log level but if needed I certainly can.

RyanLettieri and others added 6 commits January 4, 2024 09:13
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Ryan Lettieri <ryanLettieri@microsoft.com>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40617f1) 76.23% compared to head (0cf104e) 76.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #978      +/-   ##
============================================
+ Coverage     76.23%   76.29%   +0.06%     
- Complexity     1462     1463       +1     
============================================
  Files           138      138              
  Lines          4489     4497       +8     
  Branches        524      524              
============================================
+ Hits           3422     3431       +9     
  Misses          784      784              
+ Partials        283      282       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artursouza artursouza merged commit 81a3058 into dapr:master Jan 6, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow Log Enhancements
3 participants