Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify example pubsub #558

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Dec 1, 2023

Description

please refer to issue #557

Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN requested review from a team as code owners December 1, 2023 03:29
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d33c5a4) 100.00% compared to head (5b2a838) 35.29%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/actors/client/ActorClient/ActorClientHTTP.ts 0.00% 9 Missing ⚠️
src/actors/ActorId.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #558       +/-   ##
============================================
- Coverage   100.00%   35.29%   -64.71%     
============================================
  Files            1       91       +90     
  Lines            6    10450    +10444     
  Branches         1      412      +411     
============================================
+ Hits             6     3688     +3682     
- Misses           0     6703     +6703     
- Partials         0       59       +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MregXN <mregxn@gmail.com>
@shubham1172 shubham1172 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into dapr:main with commit d2cc38e Dec 5, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants