New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check outbound healthz endpoint on sidecar wait #611
Comments
@dapr/maintainers-python-sdk For this one, can I modify the existing |
Making HTTP calls within the gRPC client might be unexpected behavior for some users: The good news is that there is already precedent for using both protocols at the same time: The service invocation client in the Dapr Python SDK defaults to HTTP unless otherwise configured. And Actors are HTTP only right now! Officially the recommended way is to perform service invocation with native libraries however, rather than using the Dapr SDK. I would prefer if the runtime were to implement a native gRPC health method. But short of that, I think we can create a blocking utility method that calls the HTTP outbound health endpoint and retries until that passes. I suggest we add a new |
Based on the current usages, I only see the |
It might be nice for anything which talks to the sidecar to first wait to make sure Dapr is ready. So if it's missing it should be added I think. |
Done in #670 |
Feature request
Similar to dotnet sdk check the outbound healthz endpoint for checking if sidecar is ready.
https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.Client/DaprClientGrpc.cs#L1790
Even if the port is open, Dapr might not be ready yet.
Current behavior
Python only waits to check if the port is available and socket connection can be created.
https://github.com/dapr/python-sdk/blob/master/dapr/clients/grpc/client.py#L1431
RELEASE NOTE:
The text was updated successfully, but these errors were encountered: