Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapr.yml updates #955

Closed
wants to merge 10 commits into from
Closed

dapr.yml updates #955

wants to merge 10 commits into from

Conversation

hhunter-ms
Copy link
Contributor

Description

Update quickstarts based on dapr/docs#3860 errors

  • Moved dapr.yaml into order-processor directory where applicable
  • Updated resources and app dir paths

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: dapr/docs#3860

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@paulyuk
Copy link
Contributor

paulyuk commented Feb 11, 2024

Hi @hhunter-ms - I don't think we should make this change. Putting dapr.yaml a folder higher than app ensures that multi app run will work too. Could you walk me through why we feel it's important to move? I think the issue youre seeing should be tackled another way.

Also note the tests failed.

@paulyuk paulyuk self-requested a review February 11, 2024 21:07
@paulyuk paulyuk added this to the 1.13 milestone Feb 11, 2024
@hhunter-ms
Copy link
Contributor Author

I had opened for an issue that seems to have been resolved - the quickstarts work as they should! closing

@hhunter-ms hhunter-ms closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deficiencies in the steps updated with the multi-app run feature that comes with v12
2 participants