Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.js - process.env.STATE_STORE_NAME #958

Merged
merged 1 commit into from Feb 19, 2024

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Dec 13, 2023

Description

Allow to change the STATE_STORE_NAME for the Node app via an environment variable. Default still remain statestore if no value is supllied in this environment variable. So no side effect with existing behavior/configuration/docs.

The use case is when the name of the associated Component created for me is not statestore, I need a way to dynamically change this value without having to change the code and rebuild/repackage the Node app.

Issue reference

None yet, let me know if you want I create one.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mathieu-benoit thank you for the contribution. While it adds the slightest complexity to quickstart I'm good with it and the value it brings. Is there any chance you'd be willing to contribute this in all the rest of the languages?

@paulyuk paulyuk added this to the 1.13 milestone Feb 11, 2024
@paulyuk paulyuk changed the base branch from master to release-1.13 February 19, 2024 22:18
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution @mathieu-benoit

@paulyuk paulyuk merged commit 6a1984a into dapr:release-1.13 Feb 19, 2024
1 check passed
@mathieu-benoit mathieu-benoit deleted the patch-1 branch February 19, 2024 23:17
@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Feb 19, 2024

Thanks for your review, @paulyuk! And sorry for the delay on getting back to you.

it adds the slightest complexity to quickstart

Just to make sure, it doesn't add any complexity in the sense that's optional/seemless and that the default behavior, not passing the STATE_STORE_NAME will take the previous/default value, right?

Is there any chance you'd be willing to contribute this in all the rest of the languages?

Happy to do so, just to make sure, it's just about the Python one, right? https://github.com/dapr/quickstarts/tree/master/tutorials/hello-world/python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants