Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified actor state persistence description #961

Merged

Conversation

WhitWaldo
Copy link
Contributor

Description

The previous language used in the description in this quickstart was confusing and has spawned at least two questions about it that I've seen in the Discord channel. Updated to reflect that while changes to the state are made to the cache on a per-actor basis, but that an explicit call to SaveStateAsync is required to persist the state changes to the underlying actor state store.

I didn't make any code changes - just updated a comment in a method.

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

None: Question raised in Discord.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

WhitWaldo and others added 4 commits December 29, 2023 20:01
…tivities must be performed by the user for persistance. Previous wording was confusing.

signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whitson.waldo@gmail.com>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
…language' into updated-actor-csharp-quickstart-language
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice clarification. LGTM. Thank you for this @WhitWaldo

@paulyuk paulyuk added this to the 1.13 milestone Feb 11, 2024
@paulyuk paulyuk merged commit d718efe into dapr:master Feb 11, 2024
1 check passed
@WhitWaldo WhitWaldo deleted the updated-actor-csharp-quickstart-language branch February 14, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants