Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct readme #975

Merged
merged 3 commits into from Feb 19, 2024
Merged

correct readme #975

merged 3 commits into from Feb 19, 2024

Conversation

DeepanshuA
Copy link
Contributor

Description

Correct README for python wf quickstart

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #974

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 52-55 are also not present / need removing

@paulyuk paulyuk self-requested a review February 11, 2024 21:02
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @DeepanshuA

Could you please target this PR against the release-1.13 branch base, and then i will approve/merge? thx

@paulyuk paulyuk added this to the 1.13 milestone Feb 11, 2024
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA changed the base branch from master to release-1.13 February 19, 2024 15:30
@DeepanshuA
Copy link
Contributor Author

Looks good @DeepanshuA

Could you please target this PR against the release-1.13 branch base, and then i will approve/merge? thx

Please review now. Thanks

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@paulyuk paulyuk merged commit 0d128bf into dapr:release-1.13 Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python (sdk) workflow quickstart
3 participants