Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deduplicate item at slice appending #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
60 changes: 58 additions & 2 deletions merge.go
Expand Up @@ -40,6 +40,7 @@ func isExportedComponent(field *reflect.StructField) bool {
type Config struct {
Overwrite bool
AppendSlice bool
deduplicateSliceAppending bool
TypeCheck bool
Transformers Transformers
overwriteWithEmptyValue bool
Expand Down Expand Up @@ -171,7 +172,31 @@ func deepMerge(dst, src reflect.Value, visited map[uintptr]*visit, depth int, co
if srcSlice.Type() != dstSlice.Type() {
return fmt.Errorf("cannot append two slices with different type (%s, %s)", srcSlice.Type(), dstSlice.Type())
}
dstSlice = reflect.AppendSlice(dstSlice, srcSlice)
if !config.deduplicateSliceAppending {
dstSlice = reflect.AppendSlice(dstSlice, srcSlice)
} else {
for i := 0; i < srcSlice.Len(); i++ {
srcElement := srcSlice.Index(i)
if srcElement.CanInterface() {
srcElement = reflect.ValueOf(srcElement.Interface())
}
var found bool
for j := 0; j < dstSlice.Len(); j++ {
dstElement := dstSlice.Index(j)
if dstElement.CanInterface() {
dstElement = reflect.ValueOf(dstElement.Interface())
}
found = reflect.DeepEqual(srcElement.Interface(), dstElement.Interface())
if found {
break
}
}
if found {
continue
}
dstSlice = reflect.Append(dstSlice, srcSlice.Index(i))
}
}
} else if sliceDeepCopy {
i := 0
for ; i < srcSlice.Len() && i < dstSlice.Len(); i++ {
Expand Down Expand Up @@ -215,7 +240,31 @@ func deepMerge(dst, src reflect.Value, visited map[uintptr]*visit, depth int, co
if src.Type() != dst.Type() {
return fmt.Errorf("cannot append two slice with different type (%s, %s)", src.Type(), dst.Type())
}
dst.Set(reflect.AppendSlice(dst, src))
if !config.deduplicateSliceAppending {
dst.Set(reflect.AppendSlice(dst, src))
} else {
for i := 0; i < src.Len(); i++ {
srcElement := src.Index(i)
if srcElement.CanInterface() {
srcElement = reflect.ValueOf(srcElement.Interface())
}
var found bool
for j := 0; j < dst.Len(); j++ {
dstElement := dst.Index(j)
if dstElement.CanInterface() {
dstElement = reflect.ValueOf(dstElement.Interface())
}
found = reflect.DeepEqual(srcElement.Interface(), dstElement.Interface())
if found {
break
}
}
if found {
continue
}
dst.Set(reflect.Append(dst, src.Index(i)))
}
}
} else if sliceDeepCopy {
for i := 0; i < src.Len() && i < dst.Len(); i++ {
srcElement := src.Index(i)
Expand Down Expand Up @@ -331,6 +380,13 @@ func WithAppendSlice(config *Config) {
config.AppendSlice = true
}

// WithAppendSliceNonRepeated will make merge append slices instead of overwriting it,
// and deduplicate the slices.
func WithAppendSliceNonRepeated(config *Config) {
config.AppendSlice = true
config.deduplicateSliceAppending = true
}

// WithTypeCheck will make merge check types while overwriting it (must be used with WithOverride).
func WithTypeCheck(config *Config) {
config.TypeCheck = true
Expand Down
4 changes: 4 additions & 0 deletions mergo_test.go
Expand Up @@ -301,6 +301,10 @@ func TestSlice(t *testing.T) {
testSlice(t, []int{1}, []int{2, 3}, []int{1, 2, 3}, mergo.WithAppendSlice, mergo.WithOverride)
testSlice(t, []int{1}, []int{}, []int{1}, mergo.WithAppendSlice)
testSlice(t, []int{1}, nil, []int{1}, mergo.WithAppendSlice)
testSlice(t, nil, []int{1}, []int{1}, mergo.WithAppendSliceNonRepeated)
testSlice(t, []int{1}, []int{1}, []int{1}, mergo.WithAppendSliceNonRepeated)
testSlice(t, []int{1, 3}, []int{1, 2}, []int{1, 3, 1, 2}, mergo.WithAppendSlice)
testSlice(t, []int{1, 3}, []int{1, 2}, []int{1, 3, 2}, mergo.WithAppendSliceNonRepeated)
}

func TestEmptyMaps(t *testing.T) {
Expand Down