Add new WithSliceDeepMerge config option #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added validations to some reflection calls that were causing panic: "reflect: call of reflect.Value.IsZero on zero Value"
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -231,6 +267,38 @@ func deepMerge(dst, src reflect.Value, visited map[uintptr]*visit, depth int, co | |||
| return | |||
| } | |||
| } | |||
| } else if sliceDeepMerge { | |||
There was a problem hiding this comment.
Avoid deeply nested control flow statements.
| @@ -189,7 +193,39 @@ func deepMerge(dst, src reflect.Value, visited map[uintptr]*visit, depth int, co | |||
| return | |||
| } | |||
| } | |||
| } else if sliceDeepMerge { | |||
| if srcSlice.Len() > dstSlice.Len() { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| @@ -231,6 +267,38 @@ func deepMerge(dst, src reflect.Value, visited map[uintptr]*visit, depth int, co | |||
| return | |||
| } | |||
| } | |||
| } else if sliceDeepMerge { | |||
| if src.Len() > dst.Len() { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Codeclimate issues haven't been fixed, also no new features will be added to v1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a new feature to make it possible to deeply merge slices within maps by combining their contents.
Can be considered as a continuation of #180