Fix auto-watch when running npm run test:inject:debug
#8124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattalxndr
commented
Feb 3, 2022
|
Not sure why rollup is putting the generated test JS next to the TS files, or if that's what's desired, but I added a few lines to .gitignore to address that. |
Gusted
reviewed
Feb 3, 2022
| @@ -88,7 +88,7 @@ | |||
| "karma-coverage": "2.1.0", | |||
| "karma-firefox-launcher": "2.1.2", | |||
| "karma-jasmine": "4.0.1", | |||
| "karma-rollup-preprocessor": "7.0.7", | |||
| "karma-rollup-preprocessor": "github:jlmakes/karma-rollup-preprocessor#master", | |||
There was a problem hiding this comment.
Let's wait what they say, maybe we can avoid using this and use the next update.
mattalxndr
commented
Feb 6, 2022
Gusted
approved these changes
Feb 6, 2022
|
Everything's resolved except for this: You did mention you wanted to wait for jlmakes/karma-rollup-preprocessor to be updated so we wouldn't need to deal with the URL in the package.json. |
|
The push from last night was just to rebase onto master |
Well seems like they didn't update so it's fine then. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
npm run test:inject:debug, watching/reloading is done by the karma-rollup-preprocessor plugin. That plugin needed to be upgraded to its prerelease version at master before this was fixed.A screencast that shows the problem and the fix:
Side note, I've left a note over at jlmakes/karma-rollup-preprocessor asking when the new version will be coming out, at which time you would be able to remove the URL from package.json.