Better Makernotes handling: #302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Skip (known) LSI1 binary makernotes 2) Check IFD Entries count against tag data count, skip if too big
kmilos
reviewed
Sep 6, 2021
| @@ -159,7 +160,9 @@ TiffRootIFDOwner TiffIFD::parseMakerNote(NORangesSet<Buffer>* ifds, | |||
| bs.skipBytes(newPosition); | |||
| }; | |||
|
|
|||
| if (bs.hasPrefix("AOC\0", 4)) { | |||
| if (bs.hasPrefix("LSI1\0", 5)) { // Skip LSI1 makernotes | |||
There was a problem hiding this comment.
Maybe be more verbose in the comments that this indicates "LaserSoft Imaging (SilverFast)" for posterity?
There was a problem hiding this comment.
If the text of the comment is the only thing that prevents Roman from accepting this patch, then I will certainly change it. Let's wait for his opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #283