Skip to content

Commit

Permalink
Fix compatibility with package:logger (#3515)
Browse files Browse the repository at this point in the history
Fixes #3514

Add a forwarding implementation of `onLevelChanged` which was added in
the `Logger` class.

Update upper bound SDK constraint to avoid pub publish warning.

Remove `dependency_overrides` section in `pubspec.yaml` since there is a
separate overrides file.
  • Loading branch information
natebosch committed May 24, 2023
1 parent 5d6da09 commit 4e9615e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
4 changes: 3 additions & 1 deletion build_runner_core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## 7.2.9-wip
## 7.2.9

- Fix compatibility with `package:logging` version `1.2.0`.

## 7.2.8

Expand Down
3 changes: 3 additions & 0 deletions build_runner_core/lib/src/logging/build_for_input_logger.dart
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,7 @@ class BuildForInputLogger implements Logger {
@override
void warning(Object? message, [Object? error, StackTrace? stackTrace]) =>
_delegate.warning(message, error, stackTrace);

@override
Stream<Level?> get onLevelChanged => _delegate.onLevelChanged;
}
10 changes: 3 additions & 7 deletions build_runner_core/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: build_runner_core
version: 7.2.9-wip
version: 7.2.9
description: Core tools to organize the structure of a build and run Builders.
repository: https://github.com/dart-lang/build/tree/master/build_runner_core

environment:
sdk: ">=2.19.0 <3.0.0"
sdk: ">=2.19.0 <4.0.0"

platforms:
linux:
Expand All @@ -22,7 +22,7 @@ dependencies:
glob: ^2.0.0
graphs: ^2.0.0
json_annotation: ^4.8.1
logging: ^1.0.0
logging: ^1.2.0
meta: ^1.3.0
package_config: ^2.0.0
path: ^1.8.0
Expand All @@ -42,7 +42,3 @@ dev_dependencies:
test: ^1.16.0
test_descriptor: ^2.0.0
test_process: ^2.0.0

dependency_overrides:
build:
path: ../build

0 comments on commit 4e9615e

Please sign in to comment.