Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_logic_in_state_constructor #3138

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add no_logic_in_state_constructor #3138

wants to merge 2 commits into from

Conversation

minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Jan 10, 2022 •
edited

The constructor of a State object is not supposed to contain any logic. That logic should go into State.initState().

Closes #3059.

@coveralls
Copy link

coveralls commented Jan 10, 2022 •
edited

Coverage Status

Coverage increased (+0.01%) to 94.196% when pulling cd851e4 on minhqdao:no-logic-in-state-constructor into f02e84e on dart-lang:master.

@srawlins
Copy link
Member

Apologies on the delayed review, but we should resolve the discussion at #3059 before landing an implementation.

@srawlins
Copy link
Member

I'll convert this to a draft PR until the discussion is resolved.

@srawlins srawlins marked this pull request as draft May 22, 2023 21:49
@minhqdao
Copy link
Contributor Author

Apologies on the delayed review, but we should resolve the discussion at #3059 before landing an implementation.

No worries. I just thought in the beginning that this was going to be very straightforward and wouldn't require much discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: no_logic_in_state_constructor
3 participants
@minhqdao @coveralls @srawlins