Add resource identifiers for linking #1117
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d91a17a.
mosuem
force-pushed
the
addResourceIdentifiersForLinking
branch
from
16d0407
to
ef40a65
Compare
commit e3d9b0e Author: Moritz <mosum@google.com> Date: Wed May 8 10:28:50 2024 +0200 Adapt casing commit 60604a2 Author: Moritz <mosum@google.com> Date: Wed May 8 10:21:58 2024 +0200 Refactor add link asset test commit 12076be Author: Moritz <mosum@google.com> Date: Tue May 7 11:26:58 2024 +0200 Add todo commit 2532c8b Author: Moritz <mosum@google.com> Date: Tue May 7 10:29:37 2024 +0200 Rename commit 4e7ba0e Author: Moritz <mosum@google.com> Date: Tue May 7 10:28:09 2024 +0200 Add to manifest commit 50ecb95 Author: Moritz <mosum@google.com> Date: Tue May 7 10:25:52 2024 +0200 Add test project adding assets in link commit 9e55614 Author: Moritz <mosum@google.com> Date: Mon May 6 17:35:30 2024 +0200 Add argument to drop dylib testcase commit 14a856c Author: Moritz <mosum@google.com> Date: Mon May 6 17:33:00 2024 +0200 Move resource test commit 884c505 Author: Moritz <mosum@google.com> Date: Fri May 3 16:17:49 2024 +0200 Fix test commit 49ec442 Author: Moritz <mosum@google.com> Date: Fri May 3 14:02:27 2024 +0200 Add to manifest commit 0950ec6 Author: Moritz <mosum@google.com> Date: Fri May 3 13:12:43 2024 +0200 Remove wrong example from CI commit bf76046 Author: Moritz <mosum@google.com> Date: Fri May 3 13:04:44 2024 +0200 Add another example commit 3f5bd87 Author: Moritz <mosum@google.com> Date: Thu May 2 17:25:30 2024 +0200 Remove resources from protocol
auto-submit bot
pushed a commit
that referenced
this pull request
May 8, 2024
Support a `hook/link.dart` script, which executes after kernel compilation. The SDK changes to make this work are in https://dart-review.googlesource.com/c/sdk/+/338380. The link script receives as input a list of assets produced by `hook/build.dart` scripts. In a `hook/build.dart`, users can specify if an asset should be sent to a link script, and give the name of the package containing that script. All assets destined for a particular link script are collected and given as input. In #1117, the link scripts get as additional input tree shaking information collected during kernel compilation, to enable link scripts to remove or add assets based on usage of symbols in Dart code. --- <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/wiki/External-Package-Maintenance#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
github-actions
bot
removed
package:native_assets_cli
package:native_assets_builder
labels
This reverts commit d91a17a.
github-actions
bot
added
package:native_assets_cli
package:native_assets_builder
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.