Added "struct syntax" to AST #1140
Conversation
pkgs/swiftgen/swift2objc/Sources/swift2objc/AST/AccessModifier.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/Sources/swift2objc/AST/AccessModifier.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/Sources/swift2objc/AST/ParameterSyntax.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/Tests/swift2objcTests/swift2objcTests.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/Sources/swift2objc/AST/StructSyntax/StructMemberSyntax.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/Sources/swift2objc/AST/TypeSyntax.swift
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/lib/swiftgen.dart
Outdated
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| library swiftgen; |
| } | ||
|
|
||
| class GenericType extends ReferredType { | ||
| GenericType({required super.id}); |
There was a problem hiding this comment.
Should this have a name field? Somewhere to stick the "T"?
There was a problem hiding this comment.
You're right actually I missed it.
Added :)
| import 'declaration.dart'; | ||
| import 'referred_type.dart'; | ||
|
|
||
| class CompoundDeclaration extends Declaration { |
There was a problem hiding this comment.
Can you add a short comment to each of these classes and their fields saying what Swift language concept it represents?
There was a problem hiding this comment.
I will, but first I added AST models for class, struct, and protocol. I'm using abstract interfaces to declare common fields. I was extending abstract classes initially, but I felt like interfaces are more flexible.
I'm not sure if this approach has any drawbacks, so can you please check things out first in case there're any drawbacks?
There was a problem hiding this comment.
The class modifiers seem fine to me. I don't use them very often tbh (other than abstract). Is there a reason ObjcAnnotatable is an interface but not abstract?
There was a problem hiding this comment.
I guess the main drawback is it's a bit verbose. Since the fields are abstract, you're having to redeclare them in all the child classes, with @override, so that's 3 lines per field instead of 1.
In the meeting you said you wanted to do this to avoid writing a constructor. If that's the only reason, then I'm pretty sure it would be less code overall to just write the constructor and avoid redeclaring the fields in the child classes.
pkgs/swiftgen/swift2objc/lib/src/ast/_core/interfaces/enum_declaration.dart
Outdated
Show resolved
Hide resolved
pkgs/swiftgen/swift2objc/lib/src/ast/_core/interfaces/paramable.dart
Outdated
Show resolved
Hide resolved
| import 'declaration.dart'; | ||
| import 'referred_type.dart'; | ||
|
|
||
| class CompoundDeclaration extends Declaration { |
There was a problem hiding this comment.
I guess the main drawback is it's a bit verbose. Since the fields are abstract, you're having to redeclare them in all the child classes, with @override, so that's 3 lines per field instead of 1.
In the meeting you said you wanted to do this to avoid writing a constructor. If that's the only reason, then I'm pretty sure it would be less code overall to just write the constructor and avoid redeclaring the fields in the child classes.
Created a swift2objc "package" with AST models.
#1143