Support publishing to a hosted-url with a /path #3244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
added
the
type-bug
athomas
requested changes
Nov 30, 2021
athomas
approved these changes
Nov 30, 2021
|
Hey Guys, can confirm this fix has done the trick for us. Thanks so much for looking @jonasfj! |
|
Merged in dcb6aba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a slash to much when publishing to custom hosted pub servers with a
/pathin the hosted-url.I'm pretty sure that if the URL doesn't have any path segments then it doesn't matter if we do:
server.resolve('/api/packages/versions/new');(wrong),server.resolve('api/packages/versions/new');So this change should only affect cases where
PUB_HOSTED_URLorpublish_tocontains path-segments.This is not the prettiest of tests, but that might be subject for cleanup another day.