Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isolates.md: Robust Example Fix #5725

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

maryamshal
Copy link
Contributor

@maryamshal maryamshal commented Apr 16, 2024

Fix robust example inconsistency. The constructor signature changes order of parameters mid example which causes issues for a person following along step by step.

Fix Robust example in consistency. The constructor signature changes order of parameters mid example which causes issues for a person following along step by step.
Copy link

google-cla bot commented Apr 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@MaryaBelanger
Copy link
Contributor

Hi @maryamshal, thanks for fixing this! Could you also update the code excerpt source for each of these changes (that's why the build is failing, both the markdown page and the source for example code need to be updated).

You can find the source of a code block right above it usually, indicated by the <?code excerpt ... directive. So on lines 546 and 664 you can see that the source corresponding to the changes you made are in:

  • examples/concurrency/lib/robust_ports_example/start.dart line 21, and
  • examples/concurrency/lib/robust_ports_example/spawn_2.dart line 33

Make the same changes there and we should be all set! (might help to follow the instructions in the readme too, but it might not be necessary).

If you're having trouble just let us know and we can take over that part for you, Thanks!

@parlough
Copy link
Member

/gcbrun

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and opening the PR! Having the order be consistent makes sense and will definitely help readers :)

I went ahead and updated the source .dart files for these snippets as well.

@dart-github-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit b57e5c4):

https://dart-dev--pr5725-patch-3-tqwx5spc.web.app

@parlough parlough merged commit 694b113 into dart-lang:main May 23, 2024
10 checks passed
atsansone pushed a commit to atsansone/site-www that referenced this pull request May 29, 2024
Fix robust example inconsistency. The constructor signature changes
order of parameters mid example which causes issues for a person
following along step by step.

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants