-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update isolates.md: Robust Example Fix #5725
Conversation
Fix Robust example in consistency. The constructor signature changes order of parameters mid example which causes issues for a person following along step by step.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @maryamshal, thanks for fixing this! Could you also update the code excerpt source for each of these changes (that's why the build is failing, both the markdown page and the source for example code need to be updated). You can find the source of a code block right above it usually, indicated by the
Make the same changes there and we should be all set! (might help to follow the instructions in the readme too, but it might not be necessary). If you're having trouble just let us know and we can take over that part for you, Thanks! |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and opening the PR! Having the order be consistent makes sense and will definitely help readers :)
I went ahead and updated the source .dart
files for these snippets as well.
Visit the preview URL for this PR (updated for commit b57e5c4): |
Fix robust example inconsistency. The constructor signature changes order of parameters mid example which causes issues for a person following along step by step. --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>
Fix robust example inconsistency. The constructor signature changes order of parameters mid example which causes issues for a person following along step by step.