Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Document dart pub downgrade --tighten #5807

Merged
merged 3 commits into from
May 22, 2024
Merged

[3.5] Document dart pub downgrade --tighten #5807

merged 3 commits into from
May 22, 2024

Conversation

jonasfj
Copy link
Member

@jonasfj jonasfj commented May 13, 2024

Landed in dart-lang/pub#4245

Probably won't be out until Dart 3.5

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented May 13, 2024

Visit the preview URL for this PR (updated for commit ade6794):

https://dart-dev--pr5807-jonasfj-patch-3-br9fkqc3.web.app

@jonasfj
Copy link
Member Author

jonasfj commented May 13, 2024

Should we close this PR, or leave it open until 3.5.0 goes out?

Is there a mechanism for landing stuff a few days ahead of next next release 🤣

(documentation for this feature isn't important, it's sort of an obscure little extra, bit so it's also fine to close the this PR, make a calendar note to reopen it, and if we forget that's a risk we can live with).

@MaryaBelanger MaryaBelanger changed the title Document dart pub downgrade --tighten [3.5] Document dart pub downgrade --tighten May 22, 2024
Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonas, I think it's fine to leave it open until 3.5. I added some things to the title and description to hopefully make sure that doesn't happen!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've added a version note so we can land this now and benefit beta/dev users and worry less about tracking this. I revisit version notes alongside releases if anything changes.

@parlough parlough merged commit 3ac4e6a into main May 22, 2024
10 checks passed
@parlough parlough deleted the jonasfj-patch-3 branch May 22, 2024 20:02
atsansone pushed a commit to atsansone/site-www that referenced this pull request May 29, 2024
Landed in dart-lang/pub#4245

Probably won't be out until Dart 3.5

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants