-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better prerelease docs #5808
Better prerelease docs #5808
Conversation
Visit the preview URL for this PR (updated for commit 2748f6d): |
src/content/tools/pub/publishing.md
Outdated
While `pub` prefers stable releases the same way it prefers newer versions, | ||
the version solver does not attempt all solutions and may pick a prerelease, | ||
even when a resolution that doesn't use prelreases exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could expand to something like:
While `pub` prefers stable releases the same way it prefers newer versions, | |
the version solver does not attempt all solutions and may pick a prerelease, | |
even when a resolution that doesn't use prelreases exists. | |
While `pub` prefers stable releases the same way it prefers newer versions, | |
the version solver is applying its heuristics greedily, and stops at the first solution it finds. Thus it might end up stuck at a local maximum, with a solution including prereleases even though a solution without those exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do that, I wouldn't mind -- but it does get rather technical.
Personally, I prefer the shorter less technical thing I wrote. But I don't really care, I just want the nonsense that was there before to go away, and replace it with something that is at-least somewhat sensible.
Even if it's not perfect, it's better than what didn't make sense :D
Co-authored-by: Sigurd Meldgaard <sigurdm@google.com>
I couldn't understand what the thing it said before meant.
Then I saw that I wrote it 5 years ago 馃檲 馃檲 馃檲
Then I saw that the PR was edited twice #1785 馃ぃ 馃ぃ 馃ぃ
So what was:
Became:
and eventually what landed was:
There is some discussion of the issue here: #1785 (comment)
I suppose we could also say:
Which is closer to what it already said, but I'm not sure we want to assuming anyone knows what a "stable package" is, I certainly don't. It's probably a package that has a stable release, but it feels a bit wild just introduce new terms like that with a formal definition.
Also it's nice to have:
pub
prefers stable releases the same way it prefers newer versions"Feel free to use other words, this is really a corner case.