Skip to content

Commit

Permalink
Use Chromium binary from system for capturing screenshots
Browse files Browse the repository at this point in the history
This commit makes screenshot tests work on macOS running on Apple silicon at
the cost of adding Chromium as an external dependency.

See puppeteer/puppeteer#6622 for more details.
  • Loading branch information
dassencio committed Feb 28, 2023
1 parent 02b1770 commit f944501
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions runScreenshotTests
Expand Up @@ -50,6 +50,8 @@ do
test_details="Target path: $(magenta $target_path) | "
test_details+="Viewport width: $(magenta $viewport_width)"
echo -en "[$(gray ....)] ${test_details} "
PUPPETEER_EXECUTABLE_PATH=$(which chromium) \
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true \
./comparePages $target_path $viewport_width && {
echo -e "\r[$(bold_green PASS)] ${test_details}"
} || {
Expand Down

0 comments on commit f944501

Please sign in to comment.