Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrote test for joining tables with no rows #600

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Wrote test for joining tables with no rows #600

merged 1 commit into from
Sep 24, 2023

Conversation

jerrying123
Copy link
Contributor

@jerrying123 jerrying123 commented Sep 7, 2023 •
edited

[X] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
Wrote test for joining tables with no rows in tables.py

adnanhemani
adnanhemani approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR for a quick coverage gain. If you'd like another low-hanging fruit PR, we can likely delete the same code from Table#_join about checking empty tables.

@adnanhemani adnanhemani merged commit 2c706e2 into data-8:master Sep 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanhemani adnanhemani adnanhemani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerrying123 @adnanhemani