tables.py test #609
Closed
tables.py test #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @add-itya - given that the columns are a NumPy array, it is pretty much a requirement that they have the same object types. Given that, I'm inclined to close this PR, as it is unlikely that there is any change related here that may still be useful to the repo. Did you see any test coverage that is not covered without this check? I'm glad to take a look if that's the case - I wasn't able to verify quickly as the GitHub Action above (which runs the test suite and coverage checker) failed. Please take a look at that if you think this change still helps with the code coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X] Wrote test for feature
[ ] Added changes to CHANGELOG.md
Changes proposed:
I added functionality to check column entry types are consistent. I saw that there are functions that check the values of the basic tables, and thought it would be nice to add a check for their types. Please let me know if anything is missing, thanks :)