Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Array Protocol & improve static typing support #589

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add an Array Protocol & improve static typing support #589

wants to merge 7 commits into from

Commits on Sep 21, 2023

  1. refactor Array as a Protocol 

    Signed-off-by: nstarman <nstarman@users.noreply.github.com>
    @nstarman
    nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    59356f0 View commit details
    Browse the repository at this point in the history

  2. Add a couple of type: ignore comments for __eq__ and __ne__

    @rgommers @nstarman
    rgommers authored and nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e6fefe8 View commit details
    Browse the repository at this point in the history

  3. Resolve some Sphinx doc build errors 

    Sphinx doesn't set `TYPE_CHECKING`, but does use the type annotations.
`Self` is unknown to Sphinx, so should be filtered out to prevent lots
of errors.
    @rgommers @nstarman
    rgommers authored and nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    bd37ce2 View commit details
    Browse the repository at this point in the history

  4. static typing and documentation 

    Signed-off-by: nstarman <nstarman@users.noreply.github.com>
    @nstarman
    nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    b05fa34 View commit details
    Browse the repository at this point in the history

  5. Add device protocol to fix type ignore 

    Signed-off-by: nstarman <nstarman@users.noreply.github.com>
    @nstarman
    nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    95d390e View commit details
    Browse the repository at this point in the history

  6. use general Array protocol for other in comparisons 

    Signed-off-by: nstarman <nstarman@users.noreply.github.com>
    @nstarman
    nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e1e8063 View commit details
    Browse the repository at this point in the history

  7. Correct type hints in to_device and dlpack 

    Signed-off-by: nstarman <nstarman@users.noreply.github.com>
    @nstarman
    nstarman committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e2b373d View commit details
    Browse the repository at this point in the history