Setup correct target/module/moduleResolution settings for TSConfig
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change doesn't provide a usable ESM module. |
rwjblue
force-pushed
the
revert-esm-changes
branch
from
5a82a66
to
f600f2d
Compare
rwjblue
changed the title
target/module/moduleResolution settings for TSConfig
Hmm, seems to work for me locally when linked into a consumer package... 🤔 |
|
Have you tried linking this to a typescript consumer package? |
rwjblue
force-pushed
the
revert-esm-changes
branch
from
f600f2d
to
ae1a4eb
Compare
Yep! The same one that you shared a screenshot from in #35. |
gabrielcsapo
approved these changes
Aug 8, 2022
rwjblue
force-pushed
the
revert-esm-changes
branch
2 times, most recently
from
27c131e
to
e68ab4b
Compare
This partially reverts changes in c019ff4.
- Update vite + vitest to latest - use `defineConfig` from `vitest/config` instead of `vite`
This can be removed once `vitest` moves back to using `"type": "module"`
rwjblue
force-pushed
the
revert-esm-changes
branch
from
082adc5
to
70869ff
Compare
hjdivad
approved these changes
Aug 10, 2022
3 tasks
|
Created #42 to track fixing those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts some of the changes from #35
target/module/moduleResolutionsettings for TSConfigmsw/lib/node/index.jsinpackages/network/__test__/fetch-test.jsin order to get TypeScript to properly typecheck themswpatch-packageinfrastructurevitestso that we can work around issues with type resolution withinvite(fix!: use type module (revert #1411) vitest-dev/vitest#1465)