-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve ADLS2 Mount Diff and Incorrect error messages #51
Resolve ADLS2 Mount Diff and Incorrect error messages #51
Conversation
This PR ended up being a little bigger than expected as we needed to set up some infra in the code around creating the additional Azure resources needed to integration test these changes. Hopefully, this will make it easier for further tests of this nature in future :-) |
Co-authored-by: Stuart Leeks <stuart@leeks.net>
hey @lawrencegripper & @stuartleeks thanks for the PR I should be able to finish reviewing this by the afternoon today (EST) |
@stikkireddy - awesome, thanks for the update :-) |
Hey @stikkireddy - any update on this? Happy to answer any questions you may have 😃 |
LGTM @stuartleeks this still has issues with the tests sporadically and I believe the solution for making sure that the clusters api works properly after creating a workspace is proposed to be solved via #53. I will merge this in and hopefully that #53 can help successfully run this test 10/10 times successfully. |
Fixes #37 #38
Changes:
try-except
sounmount
error isn't returned in place of actual error on mount failure [ISSUE] Azure Mount ADAL throws wrong error hiding error details #37/
in directory name as mounting the root of the Datalake is a valid action (highlighted by the tests)/
in the python mount command which caused a diff to be detected [ISSUE] Azure ADAL Mount always detects diff due to extra slash #38The individual fixes for the bugs are relatively simple, majority of the work has gone into getting a repeatable end2end acceptance test setup for this Azure resource (and hopefully to use for all Azure integration tests).
Integration testing is done by running
./integration-environment-azure/run.sh
:1.This creates prereq from scratch (workspace, storage etc) in azure
2. These are output from the Terraform
prereq.tf
into environment variables3. Any go tests starting with
TestAccAzure
are invoked using this envs4. Script cleans up the environment
Would be great to get this script run as part of travis like #45 - are you happy for us to hook it up?
This work is co-authored with @stuartleeks
The tests seem to block on #33 occasionally when creating the cluster intermittent failures occur as seen before related to
associated worker environments
.