Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ADLS2 Mount Diff and Incorrect error messages #51

Merged
merged 11 commits into from May 20, 2020

Conversation

lawrencegripper
Copy link
Contributor

@lawrencegripper lawrencegripper commented May 12, 2020

Fixes #37 #38

Changes:

The individual fixes for the bugs are relatively simple, majority of the work has gone into getting a repeatable end2end acceptance test setup for this Azure resource (and hopefully to use for all Azure integration tests).

Integration testing is done by running ./integration-environment-azure/run.sh:
1.This creates prereq from scratch (workspace, storage etc) in azure
2. These are output from the Terraform prereq.tf into environment variables
3. Any go tests starting with TestAccAzure are invoked using this envs
4. Script cleans up the environment

Note: We create each environment from scratch to ensure no state from previous runs breaks tests and full end2end on new workspace is successful. When testing SKIP_CLEANUP can be used to avoid recreating the env each time. More details in the README.MD file.

Would be great to get this script run as part of travis like #45 - are you happy for us to hook it up?

This work is co-authored with @stuartleeks

The tests seem to block on #33 occasionally when creating the cluster intermittent failures occur as seen before related to associated worker environments.

image

@stuartleeks
Copy link
Contributor

This PR ended up being a little bigger than expected as we needed to set up some infra in the code around creating the additional Azure resources needed to integration test these changes. Hopefully, this will make it easier for further tests of this nature in future :-)

Co-authored-by: Stuart Leeks <stuart@leeks.net>
@stikkireddy
Copy link
Contributor

hey @lawrencegripper & @stuartleeks thanks for the PR I should be able to finish reviewing this by the afternoon today (EST)

@stuartleeks
Copy link
Contributor

@stikkireddy - awesome, thanks for the update :-)

@lawrencegripper lawrencegripper changed the title Resolve ADSL2 Mount Diff and Incorrect error messages Resolve ADLS2 Mount Diff and Incorrect error messages May 18, 2020
@stuartleeks
Copy link
Contributor

Hey @stikkireddy - any update on this? Happy to answer any questions you may have 😃

@stikkireddy
Copy link
Contributor

LGTM @stuartleeks this still has issues with the tests sporadically and I believe the solution for making sure that the clusters api works properly after creating a workspace is proposed to be solved via #53. I will merge this in and hopefully that #53 can help successfully run this test 10/10 times successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Azure Mount ADAL throws wrong error hiding error details
3 participants