Migrate index page to app router #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the documentation
…o be used in server components
1 flaky test on run #1047 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Overview > header |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #341 ↗︎
bklaing2
commented
Feb 6, 2024
There was a problem hiding this comment.
This was changed to accommodate the renaming of Source Sans Pro to Source Sans 3
jrhoads
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate the current index page from the
pagesrouter to theapproutercloses: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Serverversion in cases that they were using features supported only in thepagesrouter (e.g.useRouter). These are meant to be temporary until all of the pages are migratedreact-bootstrapisn't supported in server components. I created a'use client'wrapper for theGrid,Row,Col, andAlertcomponents because they are commonly used in server components.<script>tag into<head>when it runs it's tests, leading to hydration errors. I wrapped the contents of<head>in a<Suspense>boundary per this commentSource Sans Pro<link>in favor of importing usingnext/font/google. Of course, it is now calledSource Sans 3, so I had to remove references toSource Sans Proindoi.cssnext-plausible, and moved itsProviderinto the<head>per its documentationLearning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: