Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cluster): refactor flight service actions #15419

Merged
merged 12 commits into from May 16, 2024
Merged

refactor(cluster): refactor flight service actions #15419

merged 12 commits into from May 16, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented May 7, 2024 •
edited by drmingdrmer

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(cluster): refactor flight service actions

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label May 7, 2024
@zhang2014
Copy link
Member Author

There is still some work, but PR is ready for review. I will complete the remaining part in other PR.

@zhang2014 zhang2014 requested a review from dqhl76 May 16, 2024 07:59
@zhang2014 zhang2014 marked this pull request as ready for review May 16, 2024 08:00
dqhl76
dqhl76 approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@dqhl76 dqhl76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set priority and kill part look good to me

@zhang2014 zhang2014 enabled auto-merge May 16, 2024 08:04
@zhang2014 zhang2014 added this pull request to the merge queue May 16, 2024
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label May 16, 2024
Merged via the queue into datafuselabs:main with commit ee0a396 May 16, 2024
75 checks passed
@zhang2014 zhang2014 deleted the refactor/flight_service branch May 16, 2024 08:48
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15419-7dd4f33

note: this image tag is only available for internal use,
please check the internal doc for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqhl76 dqhl76 dqhl76 approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhang2014 @dqhl76 @BohuTANG