feat(functions): add map_contains_key scalar function

[hanxuanliang]

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

• Addresses part of Feature: Support map functions #15295

Tests

• Unit Test
• Logic Test
• Benchmark Test
• No Test - Explain why

Type of change

• Bug Fix (non-breaking change which fixes an issue)
• New Feature (non-breaking change which adds functionality)
• Breaking Change (fix or feature that could cause existing functionality not to work as expected)
• Documentation Update
• Refactoring
• Performance Improvement
• Other (please describe):

---

This change is 

[hanxuanliang]

@b41sh

When performing unit tests, I encountered a problem:

cargo test --package databend-common-functions --test it -- scalars::map::test_map --exact --show-output

error:

running 1 test
test scalars::map::test_map ... FAILED

successes:

successes:

failures:

---- scalars::map::test_map stdout ----
thread 'scalars::map::test_map' panicked at /Users/hanfox/.cargo/registry/src/rsproxy.cn-0dccff568467c15b/goldenfile-1.6.0/src/differs.rs:15:5:
assertion failed: `(left == right)`'
  left: `"ast            : map([], [])\nraw expr       : map(array(), array())\nchecked expr   : map<Array(Nothing), Array(Nothing)>(array<>(), array<>())\noptimized expr : {} :: Map(Nothing)\noutput type    : Map(..."` (truncated)
 right: `"ast            : map([], [])\nraw expr       : map(array(), array())\nchecked expr   : map<Array(Nothing), Array(Nothing)>(array<>(), array<>())\noptimized expr : {} :: Map(Nothing)\noutput type    : Map(..."` (truncated)

Differences (-left|+right):
 output type    : Boolean
 output domain  : {TRUE}
 output         : true

+

I have two areas of doubt:

1. How should I interpret this error?
2. How can I determine if my unit tests are written correctly?

Thank you for taking the time to assist me with this task.

[b41sh]

I have two areas of doubt:

1. How should I interpret this error?
2. How can I determine if my unit tests are written correctly?

Thank you for taking the time to assist me with this task.

Hi, @hanxuanliang thanks for your contribution. The unit test is failed because you missed some blank lines, just add those lines will pass the test.

Differences (-left|+right):
 output type    : Map(String, Map(String, String))
 output domain  : {[{"k1"..="k2"}], [{[{"nk1"..="nk3"}], [{"new_nv1"..="nv3"}]}]}
 output         : {'k1':{'nk1':'new_nv1'}, 'k2':{'nk3':'nv3'}}

+
 ast            : map_contains_key({'k1': 'v1', 'k2': 'v2'}, 'k1')
 raw expr       : map_contains_key(map(array('k1', 'k2'), array('v1', 'v2')), 'k1')
 checked expr   : map_contains_key<T0=String, T1=String><Map(T0, T1), String>(map<T0=String, T1=String><Array(T0), Array(T1)>(array<T0=String><T0, T0>("k1", "k2"), array<T0=String><T0, T0>("v1", "v2")), "k1")
 optimized expr : true
 output type    : Boolean
 output domain  : {TRUE}
 output         : true
+
+

you should also modify the function list file src/query/functions/tests/it/scalars/testdata/function_list.txt, add the new function in the function list.

Differences (-left|+right):
 0 map_cat(Map(Nothing), Map(Nothing)) :: Map(Nothing)
 1 map_cat(Map(Nothing) NULL, Map(Nothing) NULL) :: Map(Nothing) NULL
 2 map_cat(Map(T0, T1), Map(T0, T1)) :: Map(T0, T1)
 3 map_cat(Map(T0, T1) NULL, Map(T0, T1) NULL) :: Map(T0, T1) NULL
+0 map_contains_key(Map(Nothing), String) :: Boolean
+1 map_contains_key(Map(T0, T1), String) :: Boolean
+2 map_contains_key(Map(T0, T1) NULL, String NULL) :: Boolean NULL
 0 map_keys(Map(Nothing)) :: Array(Nothing)
 1 map_keys(Map(T0, T1)) :: Array(T0)
 2 map_keys(Map(T0, T1) NULL) :: Array(T0) NULL
 0 map_size(Map(Nothing)) :: UInt8

You can run make unit-test after development is complete, and if it doesn't report an error it means the changes were made correctly.

[b41sh]

this PR is almost OK, please fix sql logic test reviews.

[hanxuanliang]

But when I was running the SQL logic test locally, I encountered a problem:

first I need to start databend server: make run-debug. then an issue occurred while executing this command:

Databend Metasrv started
panicked at src/meta/client/src/lib.rs:47:28:
run `git fetch --tags` to solve this error,
    to learn more about this error, please visit https://crates.io/crates/semver: Error("unexpected character 'D' while parsing major version number")
   0: std::backtrace_rs::backtrace::libunwind::trace
             at /rustc/8ace7ea1f7cbba7b4f031e66c54ca237a0d65de6/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/8ace7ea1f7cbba7b4f031e66c54ca237a0d65de6/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
             ...
Databend Query start failure, cause: MetaServiceError. Code: 2001, Text = meta-client dedicated runtime error: tokio::sync::oneshot::error::RecvError: channel closed while: when recv resp from MetaGrpcClient worker.

An error occurred when starting databend-query. I initially thought it was an issue with port 8000, but even after switching to port 8001, the same problem persisted.

[b41sh]

But when I was running the SQL logic test locally, I encountered a problem:

first I need to start databend server: make run-debug. then an issue occurred while executing this command:

Databend Metasrv started
panicked at src/meta/client/src/lib.rs:47:28:
run `git fetch --tags` to solve this error,
    to learn more about this error, please visit https://crates.io/crates/semver: Error("unexpected character 'D' while parsing major version number")
   0: std::backtrace_rs::backtrace::libunwind::trace
             at /rustc/8ace7ea1f7cbba7b4f031e66c54ca237a0d65de6/library/std/src/../../backtrace/src/backtrace/libunwind.rs:104:5
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/8ace7ea1f7cbba7b4f031e66c54ca237a0d65de6/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
             ...
Databend Query start failure, cause: MetaServiceError. Code: 2001, Text = meta-client dedicated runtime error: tokio::sync::oneshot::error::RecvError: channel closed while: when recv resp from MetaGrpcClient worker.

An error occurred when starting databend-query. I initially thought it was an issue with port 8000, but even after switching to port 8001, the same problem persisted.

databend use github tags to calculate the version, otherwise the meta and query version is incorrect, which will cause the startup failed.
please run the following command first and then rebuild the target

git fetch --tags https://github.com/datafuselabs/databend.git

[b41sh]

LGTM @hanxuanliang Thanks for your contribution.

[hanxuanliang]

@b41sh Thank you for your help, I can successfully complete the development.. At the same time, during the development, I feel that the develop process of scalar func is not very clear in the documentation. Is there also support to contribute?