Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[building] refine: fix dep and clean useless code #689

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jun 1, 2021

Signed-off-by: Chojan Shang psiace@outlook.com

Summary

Changelog

  • Build/Testing/CI

Related Issues

Fixes #688

Test Plan

No test plan.

Signed-off-by: Chojan Shang <psiace@outlook.com>
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-build this PR changes build/testing/ci steps label Jun 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #689 (79112a1) into master (14a78f5) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #689   +/-   ##
======================================
- Coverage      78%     78%   -1%     
======================================
  Files         307     307           
  Lines       16569   16569           
======================================
- Hits        13023   13020    -3     
- Misses       3546    3549    +3     
Impacted Files Coverage Δ
common/flights/src/dns_resolver_test.rs 85% <ø> (ø)
common/runtime/src/runtime_test.rs 46% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a78f5...79112a1. Read the comment docs.

@PsiACE
Copy link
Member Author

PsiACE commented Jun 2, 2021

@zhang2014 It seems that there are some problems with welcome ci.

Error: Resource not accessible by integration

It may be a config error.

@BohuTANG
Copy link
Member

BohuTANG commented Jun 2, 2021

@zhang2014 It seems that there are some problems with welcome ci.

Error: Resource not accessible by integration

It may be a config error.

This action is flasky, I will remove it soon.
The welcome greeting will by the fusebots:
#601 (comment)

@BohuTANG BohuTANG merged commit 5bf901f into datafuselabs:master Jun 2, 2021
@PsiACE PsiACE deleted the fix-build branch June 2, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build datafuse
4 participants